wip: attempt to simplify workflows handling #2555
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
Oct 18, 2024
metacosm
commented
- refactor: remove now unneeded NameSetter interface
- refactor: simplify workflow handling
- refactor: initial work to combine ManagedWorkflow and regular one
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
xstefank
reviewed
Oct 22, 2024
| } | ||
|
|
||
| this.workflow = new DefaultWorkflow<>(alreadyResolved.values(), false, hasCleaner); | ||
| this.orderedSpecs = orderedSpecs; // todo: remove |
There was a problem hiding this comment.
I don't understand these todos in this class. Do you still plan to work on them in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.